Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BlockIcon Storybook stories #67186

Merged
merged 5 commits into from
Jan 8, 2025

Conversation

im3dabasia
Copy link
Contributor

What?

Related issue: #67165

Screenshots or screencast

Screen.Recording.2024-11-21.at.10.18.45.AM.mov

@im3dabasia im3dabasia requested a review from ellatrix as a code owner November 21, 2024 04:57
Copy link

github-actions bot commented Nov 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: im3dabasia <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @im3dabasia! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 21, 2024
@miminari miminari requested review from mtias and removed request for ellatrix November 28, 2024 23:55
- Demonstrate various icon rendering scenarios
@im3dabasia
Copy link
Contributor Author

Hey @t-hamano ,

When you have a moment, please review my work and give me feedback on it.

Thank you in advance!

@t-hamano t-hamano self-requested a review December 27, 2024 12:17
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

To make the story clearer, it would be a good idea to define the type of the props via the meta.argTypes.{propName}.table.type.summary field. Some components already have types defined, so you should be able to use them as a reference.

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository labels Dec 27, 2024
@im3dabasia
Copy link
Contributor Author

Hey @t-hamano,

Thank you for the review. I really appreciate it!

I have made the requested changes and was wondering if I could raise a separate PR to update the README.md for this component, as it lacks information about the props. What are your thoughts on this?

@im3dabasia im3dabasia requested a review from t-hamano January 2, 2025 09:28
@im3dabasia im3dabasia requested a review from t-hamano January 8, 2025 12:18
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 0f18e11 into WordPress:trunk Jan 8, 2025
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants